Extra details added for SMART monitoring setup#2210
Merged
Alex-Welsh merged 1 commit intostackhpc/2025.1from Mar 18, 2026
Merged
Extra details added for SMART monitoring setup#2210Alex-Welsh merged 1 commit intostackhpc/2025.1from
Alex-Welsh merged 1 commit intostackhpc/2025.1from
Conversation
Based on recent experiences with getting NVME and SSD monitoring setup.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds valuable documentation for SMART monitoring setup, including details on handling custom Prometheus Node Exporter parameters and a new feature for monitoring Drive Writes Per Day (DWPD). The changes are clear and enhance the user's understanding. I've found one point of inconsistency in the new documentation regarding which file is updated for DWPD ratings, for which I've left a suggestion.
Alex-Welsh
reviewed
Mar 13, 2026
technowhizz
reviewed
Mar 13, 2026
technowhizz
approved these changes
Mar 13, 2026
Contributor
technowhizz
left a comment
technowhizz
left a comment
There was a problem hiding this comment.
LGTM. We can add what alex suggested too.
Alex-Welsh
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on recent experiences with getting NVME and SSD monitoring setup.